ticket	summary	component	version	milestone	type	severity	owner	status	created	_changetime	_description	_reporter
484	[PATCH] patch for plugin-sunbird-022 to support multi-line ical fields	Plugin: mozilla	0.22		defect	normal	abauer	new	2007-04-23T21:53:32+03:00	2008-08-09T23:27:57+03:00	"
Great plugin, but as of 0.22, the sunbird plugin couldn't handle multiline ical fields, e.g.,:

UID:
 23493984794328745
 98432798734

Here's a patch to handle this.


{{{
--- src/tools.c 2007-03-27 06:49:54.000000000 -0500
+++ /home/buntinas/sources/opensync/libopensync-plugin-sunbird-0.22/src/tools.c 2007-04-20 17:03:30.000000000 -0500
@@ -187,8 +187,35 @@
         
     while (!feof(f))
     {
-        if (!fgets(buf, buf_size, f))
+        size_t offset = 0;
+        char *bptr = buf;
+
+        if (!fgets(bptr, buf_size - offset, f))
             break;
+            
+        while (1)
+        {  
+            char cont_char;
+
+            cont_char = fgetc(f);
+            if (cont_char == ' ' || cont_char == '\t')
+            {
+                len = strlen(bptr);
+                while (len > 0 && (bptr[len-1] == '\n' || bptr[len-1] == '\r'))
+                    --len;
+                
+                offset += len;
+                bptr += len;
+            }
+            else if (cont_char != EOF)
+            {
+                ungetc(cont_char, f);
+                break;
+            }
+            
+            if (!fgets(bptr, buf_size - offset, f))
+                break;
+        }
 
         len = strlen(buf);
         while (len > 0 && (buf[len-1] == '\n' || buf[len-1] == '\r'))

}}}
"	darbrew2000@…
540	[PATCH] gnokii-sync make fails	Plugin: gnokii	0.22		defect	normal	pkot	new	2007-08-20T18:19:21+03:00	2008-11-26T17:45:13+02:00	"Hello,

I have compiled and installed OpenSync 0.22 and the latest stabel version of gnokii.

I am now trying to complie nokii-sync and get an error while making.
{{{
karim@mon75-3-82-67-194-218:~/git/gnokii-sync> make
cd . && /bin/sh /home/karim/git/gnokii-sync/missing --run autoheader
rm -f stamp-h1
touch config.h.in
cd . && /bin/sh ./config.status config.h
config.status: creating config.h
config.status: config.h is unchanged
make  all-recursive
make[1]: Entering directory `/home/karim/git/gnokii-sync'
Making all in src
make[2]: Entering directory `/home/karim/git/gnokii-sync/src'
if /bin/sh ../libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I. -I.. -I/usr/local/include/opensync-1.0 -I/usr/local/include -I/usr/X11R6/include -I/usr/include/libxml2 -I/opt/gnome/include/glib-2.0 -I/opt/gnome/lib/glib-2.0/include     -Wall -Werror -O2 -I/usr/local/include/opensync-1.0 -I/usr/local/include -I/usr/X11R6/include -I/usr/include/libxml2 -I/opt/gnome/include/glib-2.0 -I/opt/gnome/lib/glib-2.0/include   -g -O2 -MT gnokii_calendar_format.lo -MD -MP -MF "".deps/gnokii_calendar_format.Tpo"" -c -o gnokii_calendar_format.lo gnokii_calendar_format.c; \
then mv -f "".deps/gnokii_calendar_format.Tpo"" "".deps/gnokii_calendar_format.Plo""; else rm -f "".deps/gnokii_calendar_format.Tpo""; exit 1; fi
 gcc -DHAVE_CONFIG_H -I. -I. -I.. -I/usr/local/include/opensync-1.0 -I/usr/local/include -I/usr/X11R6/include -I/usr/include/libxml2 -I/opt/gnome/include/glib-2.0 -I/opt/gnome/lib/glib-2.0/include -Wall -Werror -O2 -I/usr/local/include/opensync-1.0 -I/usr/local/include -I/usr/X11R6/include -I/usr/include/libxml2 -I/opt/gnome/include/glib-2.0 -I/opt/gnome/lib/glib-2.0/include -g -O2 -MT gnokii_calendar_format.lo -MD -MP -MF .deps/gnokii_calendar_format.Tpo -c gnokii_calendar_format.c  -fPIC -DPIC -o .libs/gnokii_calendar_format.o
if /bin/sh ../libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I. -I.. -I/usr/local/include/opensync-1.0 -I/usr/local/include -I/usr/X11R6/include -I/usr/include/libxml2 -I/opt/gnome/include/glib-2.0 -I/opt/gnome/lib/glib-2.0/include     -Wall -Werror -O2 -I/usr/local/include/opensync-1.0 -I/usr/local/include -I/usr/X11R6/include -I/usr/include/libxml2 -I/opt/gnome/include/glib-2.0 -I/opt/gnome/lib/glib-2.0/include   -g -O2 -MT gnokii_calendar_utils.lo -MD -MP -MF "".deps/gnokii_calendar_utils.Tpo"" -c -o gnokii_calendar_utils.lo gnokii_calendar_utils.c; \
then mv -f "".deps/gnokii_calendar_utils.Tpo"" "".deps/gnokii_calendar_utils.Plo""; else rm -f "".deps/gnokii_calendar_utils.Tpo""; exit 1; fi
 gcc -DHAVE_CONFIG_H -I. -I. -I.. -I/usr/local/include/opensync-1.0 -I/usr/local/include -I/usr/X11R6/include -I/usr/include/libxml2 -I/opt/gnome/include/glib-2.0 -I/opt/gnome/lib/glib-2.0/include -Wall -Werror -O2 -I/usr/local/include/opensync-1.0 -I/usr/local/include -I/usr/X11R6/include -I/usr/include/libxml2 -I/opt/gnome/include/glib-2.0 -I/opt/gnome/lib/glib-2.0/include -g -O2 -MT gnokii_calendar_utils.lo -MD -MP -MF .deps/gnokii_calendar_utils.Tpo -c gnokii_calendar_utils.c  -fPIC -DPIC -o .libs/gnokii_calendar_utils.o
if /bin/sh ../libtool --tag=CC --mode=compile gcc -DHAVE_CONFIG_H -I. -I. -I.. -I/usr/local/include/opensync-1.0 -I/usr/local/include -I/usr/X11R6/include -I/usr/include/libxml2 -I/opt/gnome/include/glib-2.0 -I/opt/gnome/lib/glib-2.0/include     -Wall -Werror -O2 -I/usr/local/include/opensync-1.0 -I/usr/local/include -I/usr/X11R6/include -I/usr/include/libxml2 -I/opt/gnome/include/glib-2.0 -I/opt/gnome/lib/glib-2.0/include   -g -O2 -MT gnokii_contact_format.lo -MD -MP -MF "".deps/gnokii_contact_format.Tpo"" -c -o gnokii_contact_format.lo gnokii_contact_format.c; \
then mv -f "".deps/gnokii_contact_format.Tpo"" "".deps/gnokii_contact_format.Plo""; else rm -f "".deps/gnokii_contact_format.Tpo""; exit 1; fi
 gcc -DHAVE_CONFIG_H -I. -I. -I.. -I/usr/local/include/opensync-1.0 -I/usr/local/include -I/usr/X11R6/include -I/usr/include/libxml2 -I/opt/gnome/include/glib-2.0 -I/opt/gnome/lib/glib-2.0/include -Wall -Werror -O2 -I/usr/local/include/opensync-1.0 -I/usr/local/include -I/usr/X11R6/include -I/usr/include/libxml2 -I/opt/gnome/include/glib-2.0 -I/opt/gnome/lib/glib-2.0/include -g -O2 -MT gnokii_contact_format.lo -MD -MP -MF .deps/gnokii_contact_format.Tpo -c gnokii_contact_format.c  -fPIC -DPIC -o .libs/gnokii_contact_format.o
cc1: warnings being treated as errors
gnokii_contact_format.c: In function 'conv_gnokii_contact_to_xml':
gnokii_contact_format.c:259: warning: enumeration value 'GN_PHONEBOOK_ENTRY_Location' not handled in switch
gnokii_contact_format.c:259: warning: enumeration value 'GN_PHONEBOOK_ENTRY_Image' not handled in switch
gnokii_contact_format.c:259: warning: enumeration value 'GN_PHONEBOOK_ENTRY_UserID' not handled in switch
gnokii_contact_format.c:259: warning: enumeration value 'GN_PHONEBOOK_ENTRY_PTTAddress' not handled in switch
gnokii_contact_format.c:259: warning: enumeration value 'GN_PHONEBOOK_ENTRY_FirstName' not handled in switch
gnokii_contact_format.c:259: warning: enumeration value 'GN_PHONEBOOK_ENTRY_LastName' not handled in switch
gnokii_contact_format.c:259: warning: enumeration value 'GN_PHONEBOOK_ENTRY_FormalName' not handled in switch
gnokii_contact_format.c:259: warning: enumeration value 'GN_PHONEBOOK_ENTRY_Nickname' not handled in switch
gnokii_contact_format.c:259: warning: enumeration value 'GN_PHONEBOOK_ENTRY_Birthday' not handled in switch
make[2]: *** [gnokii_contact_format.lo] Error 1
make[2]: Leaving directory `/home/karim/git/gnokii-sync/src'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/karim/git/gnokii-sync'
make: *** [all] Error 2
}}}

Can you help me ?

Thank you."	coq_vi
671	[PATCH] libopensync-plugin-synce-0.22 does not configure on gentoo	Plugin: synce	0.22		defect	normal	abauer	new	2008-01-23T12:20:15+02:00	2010-11-28T13:40:13+02:00	"the ./configure fails with
{{{
checking for rra_syncmgr_new in -lrra... no
configure: error: Can't find RRA library
}}}

* synce-rra-0.10.0 and
* librapi2-0.10.0
are installed

interesting part in config.log is
{{{
configure:4453: gcc -o conftest -g -O2   conftest.c -lrra  -lmimedir  >&5
/usr/lib/gcc/i686-pc-linux-gnu/4.1.2/../../../librra.so: undefined reference to `rapi_reg_set_dword'
/usr/lib/gcc/i686-pc-linux-gnu/4.1.2/../../../librra.so: undefined reference to `rapi_reg_create_key'
/usr/lib/gcc/i686-pc-linux-gnu/4.1.2/../../../librra.so: undefined reference to `CeRapiInit'
/usr/lib/gcc/i686-pc-linux-gnu/4.1.2/../../../librra.so: undefined reference to `rapi_reg_query_string'
/usr/lib/gcc/i686-pc-linux-gnu/4.1.2/../../../librra.so: undefined reference to `CeRegCloseKey'
/usr/lib/gcc/i686-pc-linux-gnu/4.1.2/../../../librra.so: undefined reference to `rapi_reg_query_dword'
/usr/lib/gcc/i686-pc-linux-gnu/4.1.2/../../../librra.so: undefined reference to `CeStartReplication'
/usr/lib/gcc/i686-pc-linux-gnu/4.1.2/../../../librra.so: undefined reference to `rapi_reg_open_key'
/usr/lib/gcc/i686-pc-linux-gnu/4.1.2/../../../librra.so: undefined reference to `rapi_reg_set_string'
/usr/lib/gcc/i686-pc-linux-gnu/4.1.2/../../../librra.so: undefined reference to `CeRegQueryValueEx'
collect2: ld returned 1 exit status
}}}

It works if I add ""-lrapi"" in the configure-script (manually oder via configure.in and running autogen.sh again)"	ello
732	[PATCH] three tiny patches for moto-sync	Plugin: moto	0.38		enhancement	normal	andrewb	new	2008-04-30T12:25:59+03:00	2008-11-23T11:34:34+02:00	"Hi, I'm using 0.36 with moto-sync from SVN and had two issues. First, there's still a reference to hashtable.reset_reports(), which doesn't exist. Second, there's some confusion WRT to timezone-aware and timezone-agnostic date values, leading to a ""TypeError: can't compare offset-naive and offset-aware datetimes"".

Yours, Florian



"	floe
1063	[PATCH] Change to osync_plugin_config_get_advancedoption_value_by_name for google-calendar	Plugin: google	0.38		defect	normal	savago	new	2009-02-15T02:18:49+02:00	2009-04-01T19:18:56+03:00	"The change to osync_plugin_config_get_advancedoption_value_by_name [Bug 1032] requires a small change in gcalendar.c.

The attached patch file is untested (I cannot even compile it as I do not have the necessary libraries installed) but is intended to fix this
"	Graham Cobb
1094	[PATCH] FindLibXml2.cmake fails if pkg-config file not found	OpenSync: Build Environment	0.38		defect	normal	bricks	assigned	2009-04-02T16:43:06+03:00	2010-03-17T09:11:40+02:00	"!FindLibXml2.cmake contains the following code:
{{{
INCLUDE( FindPkgConfig )
# Take care about libxml2.pc settings
IF ( LibXml2_FIND_REQUIRED )
  SET( _pkgconfig_REQUIRED ""REQUIRED"" )
ELSE ( LibXml2_FIND_REQUIRED )
  SET( _pkgconfig_REQUIRED """" )
ENDIF ( LibXml2_FIND_REQUIRED )

IF ( LIBXML2_MIN_VERSION )
	PKG_SEARCH_MODULE( LIBXML2 ${_pkgconfig_REQUIRED} libxml-2.0>=${LIBXML2_MIN_VERSION} )
ELSE ( LIBXML2_MIN_VERSION )
	PKG_SEARCH_MODULE( LIBXML2 ${_pkgconfig_REQUIRED} libxml-2.0 )
ENDIF ( LIBXML2_MIN_VERSION )

# Look for libxml-2.0 include dir and libraries w/o pkgconfig
IF ( NOT LIBXML2_FOUND AND NOT PKG_CONFIG_FOUND )
	FIND_PATH( ... )
	FIND_LIBRARY( ...)
	...
ENDIF ( NOT LIBXML2_FOUND AND NOT PKG_CONFIG_FOUND )
}}}

There are two problems with this approach:

First of all, on a system which does have pkg-config installed, but no .pc file for libxml2, the alternative way of looking for the library is ignored.

{{{
IF ( NOT LIBXML2_FOUND AND NOT PKG_CONFIG_FOUND )
}}}
should be changed to
{{{
IF ( NOT LIBXML2_FOUND )
}}}


Second, if the libxml2 package is required, ie. if called using something like:
{{{
FIND_PACKAGE( LibXml2 REQUIRED )
}}}
then the macro fails if the package is not found with PKG_SEARCH_MODULE, and does not consider the alternative way of looking for the library.

It seems to me that the whole {{{ ${_pkgconfig_REQUIRED} }}} part should be removed.

(I found this bug when trying to build on Windows with MinGW, where I install the libxml2 headers and libraries, but have no .pc file available)

Other .cmake files have the same problem"	henrik
1103	"[PATCH] Format ""memo"": ERROR: Unable to find conversion path"	OpenSync: Build Environment	0.38		defect	normal	bricks	new	2009-04-13T14:02:39+03:00	2009-04-13T16:34:11+03:00	"Whenever a peer is configured with format ""memo"", the following errors appear:

{{{
ERROR: Unable to find conversion path
EXIT_ERROR: osync_format_env_find_path_fn: Unable to find conversion path
EXIT_ERROR: osync_format_env_find_path: Unable to find conversion path
EXIT_ERROR: ldap_format_perform_conversion: Unable to find conversion path
main: Unable to find conversion pathERROR: main: Unable to find conversion path
EXIT_ERROR: main: Unable to find conversion path
}}}

The reason is quite simple: {{{xmlformat_note_memo.c}}} does not get built. It has been forgotten in {{{CMakeLists.txt}}}.

I attach a patch that solves this problem.


"	scriptor
1107	[PATCH] Segmentation fault with lack of permissions to write to the trace directory	OpenSync	0.38		defect	normal	dgollub	new	2009-04-15T19:43:04+03:00	2009-04-15T19:43:04+03:00	"

Segmentation fault occurs when osynctool has no write permissions
to the trace directory.

For example:

{{{
export OSYNC_TRACE=""/tmp/trace""
chmod a-rwx /tmp/trace
chown -R root:root /tmp/trace
}}}

And then running osynctool as simple user results in:

{{{
#0  0xb7f50424 in __kernel_vsyscall ()
#1  0x4ad3f460 in raise (sig=6) at ../nptl/sysdeps/unix/sysv/linux/raise.c:64
#2  0x4ad40e28 in abort () at abort.c:88
#3  0x4ad7cfed in __libc_message (do_abort=2,
    fmt=0x4ae57e68 ""*** glibc detected *** %s: %s: 0x%s ***\n"")
    at ../sysdeps/unix/sysv/linux/libc_fatal.c:170
#4  0x4ad83e1f in malloc_printerr (ptr=<value optimized out>,
    str=<value optimized out>, action=<value optimized out>) at malloc.c:5994
#5  malloc_consolidate (av=0x4ae85140) at malloc.c:4905
#6  0x4ad8592d in _int_malloc (av=0x4ae85140, bytes=8160) at malloc.c:4229
#7  0x4ad87765 in __libc_malloc (bytes=8160) at malloc.c:3551
#8  0x4ad2b79d in __gconv_open (toset=0xb6553f10 ""UTF-8//"",
    fromset=0xb6553ef0 ""ANSI_X3.4-1968//"", handle=0xb6553f38, flags=0)
    at gconv_open.c:284
#9  0x4ad2b102 in iconv_open (tocode=0x4af9d368 ""UTF-8"",
    fromcode=0x824db00 ""ANSI_X3.4-1968"") at iconv_open.c:72
#10 0x4af2c0ce in ?? () from /lib/libglib-2.0.so.0
#11 0x4af2c11c in g_iconv_open () from /lib/libglib-2.0.so.0
#12 0x4af2c70a in ?? () from /lib/libglib-2.0.so.0
#13 0x4af2cb55 in g_convert () from /lib/libglib-2.0.so.0
#14 0x4af2cf81 in g_locale_to_utf8 () from /lib/libglib-2.0.so.0
#15 0x4af6531c in g_strerror () from /lib/libglib-2.0.so.0
#16 0x4af7ac6e in g_io_channel_new_file () from /lib/libglib-2.0.so.0
#17 0xb7eddd1a in osync_trace (type=TRACE_EXIT, message=0xb7f1e7cf ""%s"")
    at /home/a0037/dev/libopensync/opensync/debug/opensync_trace.c:216
#18 0xb7ed84a9 in osync_thread_unref (thread=0x8256538)
    at /home/a0037/dev/libopensync/opensync/common/opensync_thread.c:105
#19 0xb7f03420 in osync_queue_disconnect (queue=0x8255b10, error=0xb655420c)
    at /home/a0037/dev/libopensync/opensync/ipc/opensync_queue.c:1176
#20 0xb7ed0b54 in _osync_client_hup_handler (message=0x8253378,
    user_data=0x82498b8)
    at /home/a0037/dev/libopensync/opensync/client/opensync_client.c:1560
#21 0xb7f01566 in _incoming_dispatch (source=0x824dcb0, callback=0,
    user_data=0x8249b28)
    at /home/a0037/dev/libopensync/opensync/ipc/opensync_queue.c:391
#22 0x4af43238 in g_main_context_dispatch () from /lib/libglib-2.0.so.0
#23 0x4af468e3 in ?? () from /lib/libglib-2.0.so.0
#24 0x4af46e02 in g_main_loop_run () from /lib/libglib-2.0.so.0
#25 0x4af6dc6f in ?? () from /lib/libglib-2.0.so.0
#26 0x4aec251f in start_thread (arg=0xb6554b90) at pthread_create.c:297
#27 0x4adf804e in clone () at ../sysdeps/unix/sysv/linux/i386/clone.S:130

}}}


I attach a patch against {{{libopensync/opensync/debug/opensync_trace.c}}} to solve this.



"	scriptor
1133	[PATCH] Calls to osync_format_env_register_converter() must be adjusted to changeset 5671.	Format Plugin: xmlformat	0.38		defect	normal	dgollub	new	2009-06-28T00:06:55+03:00	2009-07-01T20:32:56+03:00	"Hello,

according to 

http://opensync.org/changeset/5671

and 

http://opensync.org/ticket/1087

an ""error"" argument must be added with calls to osync_format_env_register_converter().

And, please, do not forget ticket #1103





"	scriptor
1205	[PATCH]: xmlAddChild() frees the node argument sometimes.	OpenSync: XMLFormat API	0.39		defect	normal	dgollub	new	2010-01-23T19:27:07+02:00	2010-02-07T22:12:00+02:00	"Hi,

I refer to  http://xmlsoft.org/html/libxml-tree.html#xmlAddChild

According to this, the xmlAddChild() function sometimes frees one
of its arguments.  And I have checked it: Its return value does
sometimes differ from the argument the function has been provided with.
This has consequences for the code, which I outline in two patches I try to add."	scriptor
1171	[PATCH] vformat to compile on Windows	Format Plugin: vformat	0.39	Plugin Format: vformat 0.40	enhancement	normal	henrik	new	2009-10-14T19:37:06+03:00	2009-10-25T16:50:14+02:00	"The vformat/tests/support.c file does not compile on windows (MinGW).

Patch attached.

Any comments?"	henrik
