osync_plugin_config_get_advancedoption_value_by_name returns option not value

[Graham Cobb]

The osync_plugin_config_get_advancedoption_value_by_name function is supposed to be a quick way to get the value of an advanced option from its name.

However, the function actually returns the OSyncPluginAdvancedOption itself, which has to be passed to osync_plugin_advancedoption_get_value in order to get the value.

Either the function should be re-implemented to return const char * (calling osync_plugin_advancedoption_get_value internally) or it should be renamed osync_plugin_config_get_advancedoption_by_name. I prefer the first option as that is how I am using it.

Note: this is an API change (correction).

[Graham Cobb]

Change to make osync_plugin_config_get_advancedoption_value_by_name return the option value, not the option itself, has been committed: r5262.