Ticket #1032 (closed defect: fixed)

Opened 6 years ago

Last modified 5 years ago

osync_plugin_config_get_advancedoption_value_by_name returns option not value

Reported by: Graham Cobb Owned by: Graham Cobb
Priority: high Milestone: OpenSync 0.39
Component: OpenSync Version: 0.38
Severity: blocker Keywords:
Cc:

Description

The osync_plugin_config_get_advancedoption_value_by_name function is supposed to be a quick way to get the value of an advanced option from its name.

However, the function actually returns the OSyncPluginAdvancedOption itself, which has to be passed to osync_plugin_advancedoption_get_value in order to get the value.

Either the function should be re-implemented to return const char * (calling osync_plugin_advancedoption_get_value internally) or it should be renamed osync_plugin_config_get_advancedoption_by_name. I prefer the first option as that is how I am using it.

Note: this is an API change (correction).

Change History

comment:1 Changed 5 years ago by dgollub

  • Owner dgollub deleted

comment:2 Changed 5 years ago by Graham Cobb

  • Owner set to Graham Cobb
  • Status changed from new to assigned

comment:3 Changed 5 years ago by Graham Cobb

  • Status changed from assigned to closed
  • Resolution set to fixed

Change to make osync_plugin_config_get_advancedoption_value_by_name return the option value, not the option itself, has been committed: r5262.

Note: See TracTickets for help on using tickets.