[REGRESSION TESTCASE] Format detection called on deleted objects

[Graham Cobb]

I sync from GPE to filesync and create some files. Then I delete one of the files and try the sync.

The following error is logged:

GLib-CRITICAL **: g_pattern_match_simple: assertion `string != NULL' failed

The problem is that detect_plain_as_xmlformat_contact is being called with data and size as 0, presumably for the change report for the deleted file.

It is not clear to me if this is an xmlformat bug (it should handle the detector being called with a NULL pointer) or an engine bug. It seems like an engine bug: what is a format detector supposed to do if passed no data?

Note that vformat, xmlformat and xmlformat-doc are all installed during this test.

[Graham Cobb]

Patch to not detect format of DELETED changes

[Graham Cobb]

I propose the attached patch.

[dgollub]

Slightly modified with r5145.

Since detect function didn't provide a very helpful error-handling. Since we would need to check always for osync_error_set(). Changed the API - and also protected the function to not call any detection when there is no data provided by the caller.

In the engine we avoid this call at all, by determine the ChangeType?, like you have done in your original patch!

Thanks for finding and fixing this!

[dgollub]

Reopened - we need for this a regression testcase.

Instrument mockformat's detect function and fail if detect get called and the instrumentation environment variable got set.