Ticket #563 (closed defect: fixed)

Opened 7 years ago

Last modified 7 years ago

mototool --delete works every time regardless of security question

Reported by: felixmoeller Owned by: andrewb
Priority: normal Milestone:
Component: Plugin: moto Version: 0.32
Severity: major Keywords:


http://www.opensync.org/browser/plugins/moto-sync/mototool and the version from the 0.2x branch delete all entries on the phone regardless of security question! ("About to delete all event & contact entries from the phone! Are you sure? [yn]")

The relevant code is:

57 	        print 'Are you sure? [yn] ',
58 	        if sys.stdin.read(1).lower() != 'y':
59 	            print 'Operation aborted'
60 	            return

I think there should be a sys.exit(0/1) instead of the return.

Change History

comment:1 Changed 7 years ago by felixmoeller

  • Owner changed from abauer to andrewb
  • Component changed from OpenSync to Plugin: moto

comment:2 Changed 7 years ago by andrewb

  • Status changed from new to closed
  • Resolution set to fixed

Oops! Fixed in r2704.

Note: See TracTickets for help on using tickets.