Ticket #703 (closed defect: fixed)

Opened 5 years ago

Last modified 5 years ago

ignores username at xpath /config/ssh/handheld_user

Reported by: kbloom Owned by: Graham Cobb
Priority: normal Milestone:
Component: Plugin: gpe Version: 0.36
Severity: normal Keywords:
Cc:

Description

I have a configuration to sync using <config>

<ssh>

<handheld_ip>192.168.1.102</handheld_ip> <handheld_user>user</handheld_user> <command>gpesyncd --remote</command>

</ssh>

</config>

but when I run msynctool --discover on this setup, ssh prompts me for a password for @192.168.1.102 (that's right: there's a completely blank username).

When parsing the <command> tag that comes next, the parser is improperly freeing the username. The following patch fixes this bug.

--- libopensync-plugin-gpe-0.36.orig/src/gpe_xml.c +++ libopensync-plugin-gpe-0.36/src/gpe_xml.c @@ -120,7 +120,6 @@

if (!(env->use_local
env->use_ssh)) {

osync_trace(TRACE_ERROR, "GPE-SYNC %s: <command> should only be

specified in <local> or <ssh> sections", func);

}

  • g_free(env->username);

xmlChar *str=xmlXPathCastToString(obj); env->command = g_strdup(str); xmlFree(str);

A corresponding Debian bug is at ​http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=468284

Change History

comment:1 Changed 5 years ago by Graham Cobb

  • Status changed from new to closed
  • Resolution set to fixed

Fixed: rev 3214. Thanks for the report and the patch.

Note: See TracTickets for help on using tickets.