Ticket #733 (new defect)

Opened 6 years ago

Last modified 5 years ago

at_command tag is not documented

Reported by: amilcar Owned by: bellmich
Priority: normal Milestone:
Component: Plugin: syncml Version: 0.38
Severity: normal Keywords:
Cc: bellmich

Description

Whoever committed the at_command tag into the obex-client XML configuration file did a great job. Samsung phones need that.

But he did NOT document it!

The comment tells users to read the wiki: <!-- Some devices use a non-standard compliant AT command.

This special AT command contains for example the datastores which should be synchronized. If you don't know what to do then leave this empy or visit our wiki for examples. Some devices are supported by default. If yours is not supported then please open a ticket.

-->

Guess what I read the wiki and searched for it all over the place. And NO docu is present.

I have a SGH-Z400 phone and I need the correct at_command for it

Change History

comment:1 follow-up: ↓ 2 Changed 6 years ago by dgollub

  • Cc bellmich added
  • Component changed from OpenSync to Plugin: syncml

Michael is to praise for this option:

dani@sugga:~/projects/opensync/plugins/syncml> svn praise src/syncml_obex_client.c | grep at_command
  3219   bellmich                       if (!xmlStrcmp(cur->name, (const xmlChar *)"at_command")) {

Anyway, he also implemented for samsung mobiles some obex specific AT chat code. So you only have to configure your plugin to connect via cable, without setting at_command. Additionally you have to patch libsyncml so it matches your mobile:

Index: libsyncml/transports/obex_client_samsung.c
===================================================================
--- libsyncml/transports/obex_client_samsung.c  (revision 432)
+++ libsyncml/transports/obex_client_samsung.c  (working copy)
@@ -38,6 +38,7 @@
         */
 
        if (!g_strcasecmp("D520", env->model) ||
+           !g_strcasecmp("SGH-Z400", evn->model) ||
            !g_strcasecmp("SGH-E900", env->model))
        {
                smlTrace(TRACE_INTERNAL, "%s: WebSync WiDESYNC III (Gumi, Suwon 3G)", __func__);

Michael, is there a plan to have environment variable to fake the vendor ID as temporay hardware support, instead of patching libsyncml? What do you think?

comment:2 in reply to: ↑ 1 Changed 6 years ago by dgollub

Replying to dgollub:

Michael, is there a plan to have environment variable to fake the vendor ID as temporay hardware support, instead of patching libsyncml? What do you think?

... model name/ID - not vendor ID.

comment:3 Changed 6 years ago by amilcar

How about making the above patch part of the official distribution ?

And please add some documentation, I'm a developer and I still have no clue what I should put in the at_command field. The comment tells me to read the wiki, but where is the information on the wiki.

How about providing a URL instead of writing "visit our wiki for examples". There are no examples of at_commands on the wiki.

comment:4 Changed 6 years ago by bellmich

I added all known mobiles to libsyncml (v436). Additionally I modified the comment in the config file.

@Daniel: If you want to influence the device detection via configuration then the best way is to implement support for two configuration options AT_CGMI and AT_CGMM to override the auto detection.

Best regards

Michael

comment:5 Changed 6 years ago by bellmich

  • Owner changed from dgollub to bellmich

I commited some code. You can configure now the manufacturer and the model in the obex client configuration.

libsyncml svn rev437 syncml plugin svn rev3338

comment:6 Changed 6 years ago by felixmoeller

  • Version changed from 0.39 to 0.36

the version was wrong.

comment:7 Changed 5 years ago by tuju

  • Version changed from 0.36 to 0.38
Note: See TracTickets for help on using tickets.